lkml.org 
[lkml]   [2022]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 122/207] gve: Fix GFP flags when allocing pages
    Date
    From: Shailend Chand <shailend@google.com>

    [ Upstream commit 8ccac4edc8da764389d4fc18b1df740892006557 ]

    Use GFP_ATOMIC when allocating pages out of the hotpath,
    continue to use GFP_KERNEL when allocating pages during setup.

    GFP_KERNEL will allow blocking which allows it to succeed
    more often in a low memory enviornment but in the hotpath we do
    not want to allow the allocation to block.

    Fixes: 9b8dd5e5ea48b ("gve: DQO: Add RX path")
    Signed-off-by: Shailend Chand <shailend@google.com>
    Signed-off-by: Jeroen de Borst <jeroendb@google.com>
    Link: https://lore.kernel.org/r/20220913000901.959546-1-jeroendb@google.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/google/gve/gve_rx_dqo.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/google/gve/gve_rx_dqo.c b/drivers/net/ethernet/google/gve/gve_rx_dqo.c
    index 8c939628e2d8..2e6461b0ea8b 100644
    --- a/drivers/net/ethernet/google/gve/gve_rx_dqo.c
    +++ b/drivers/net/ethernet/google/gve/gve_rx_dqo.c
    @@ -157,7 +157,7 @@ static int gve_alloc_page_dqo(struct gve_priv *priv,
    int err;

    err = gve_alloc_page(priv, &priv->pdev->dev, &buf_state->page_info.page,
    - &buf_state->addr, DMA_FROM_DEVICE, GFP_KERNEL);
    + &buf_state->addr, DMA_FROM_DEVICE, GFP_ATOMIC);
    if (err)
    return err;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-26 13:48    [W:4.121 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site