Messages in this thread | | | Date | Sun, 25 Sep 2022 16:47:27 -0700 | From | Nathan Chancellor <> | Subject | Re: [PATCH v2] Compiler Attributes: Introduce __access_*() function attribute |
| |
On Sun, Sep 25, 2022 at 01:36:22PM +0200, Miguel Ojeda wrote: > On Sun, Sep 25, 2022 at 6:46 AM Nathan Chancellor <nathan@kernel.org> wrote: > > > > The GCC docs say it is 'access', instead of '__access__'. I assume it is > > probably okay so: > > Yeah, attributes can be used either with or without double > underscores, see > https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html#Attribute-Syntax.
Aha, I figured I was missing something. That is what I get for doing a mobile review :)
> In this file, we always use the underscore ones to minimize the chance > of collisions, since the idea is that the rest of the kernel uses the > shorthands provided here.
That certainly makes sense, I think it is a little easier to read too, as it gives the attribute name a little separating from '__attribute__' and any arguments to it.
Cheers, Nathan
| |