Messages in this thread | | | Date | Fri, 23 Sep 2022 23:06:19 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 2/2][next] scsi: hptiop: Use struct_size() helper in code related to struct hpt_iop_request_scsi_command |
| |
On Thu, Sep 22, 2022 at 11:55:33AM -0500, Gustavo A. R. Silva wrote: > Prefer struct_size() over open-coded versions of idiom: > > sizeof(struct-with-flex-array) + sizeof(typeof-flex-array-elements) * count > > where count is the max number of items the flexible array is supposed to > contain. > > Link: https://github.com/KSPP/linux/issues/160 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Looks correct; thanks!
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |