Messages in this thread | | | From | Heiko Stuebner <> | Subject | Re: [PATCH 1/2] pinctrl: rockchip: add pinmux_ops.gpio_set_direction callback | Date | Fri, 23 Sep 2022 20:14:48 +0200 |
| |
Am Freitag, 23. September 2022, 16:51:40 CEST schrieb Quentin Schulz: > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > Before the split of gpio and pinctrl sections in their own driver, > rockchip_set_mux was called in pinmux_ops.gpio_set_direction for > configuring a pin in its GPIO function. > > This is essential for cases where pinctrl is "bypassed" by gpio > consumers otherwise the GPIO function is not configured for the pin and > it does not work. Such was the case for the sysfs/libgpiod userspace > GPIO handling. > > Let's re-implement the pinmux_ops.gpio_set_direction callback so that > the gpio subsystem can request from the pinctrl driver to put the pin in > its GPIO function. > > Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes") > Cc: stable@vger.kernel.org > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
| |