lkml.org 
[lkml]   [2022]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v8 7/7] remoteproc: qcom: Add support for memory sandbox
    From
    On 23/09/2022 15:05, Srinivasa Rao Mandadapu wrote:
    > Update pil driver with SMMU mapping for allowing authorised
    > memory access to ADSP firmware, by carveout reserved adsp memory
    > region from device tree file.
    >


    Thank you for your patch. There is something to discuss/improve.

    > + if (!rproc->domain)
    > + return -EINVAL;
    > +
    > + ret = of_parse_phandle_with_args(adsp->dev->of_node, "iommus", "#iommu-cells", 0, &args);

    I think your bindings do not allow iommus property.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-09-23 19:27    [W:4.136 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site