Messages in this thread | | | Date | Thu, 22 Sep 2022 16:39:42 +0200 | From | Dominik Brodowski <> | Subject | Re: [PATCH] pcmcia: Removed unused variable control. |
| |
Am Mon, Jul 25, 2022 at 06:59:55AM +0530 schrieb Souptick Joarder: > From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com> > > Kernel test robot throws below warning -> > drivers/pcmcia/omap_cf.c:127:7: warning: variable 'control' > set but not used [-Wunused-but-set-variable] > > Removed unused variable control.
From a code-generation standpoint, this is obiously correct, and probably the compiler removes that omap_readw() already. But, to be honest, I'm not perfectly sure on what the device expects -- and whether it's required to write back the control register (or parts of it). Does anyone still have the hardware (or specs)? If not, I'm tempted to apply this patch on the basis that the compiler might remove that omap_readw() anyway.
Thanks, Dominik
| |