Messages in this thread | | | Date | Fri, 23 Sep 2022 17:43:22 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v6 5/8] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes |
| |
On Thu, Sep 22, 2022 at 08:26:16AM +0000, Justin He wrote: > If there is no ghes_present flag. > What if ghes.disable is passed to kernel boot parameter and then ghes_edac is > loaded by modprobe? > Thus, ghes_edac can be loaded even if ghes is disabled. (ghes_dev list is null)
Yes, and what happens if ghes_dev is NULL?
The other drivers would do in their init function:
struct list_head *ghes_devs;
ghes_devs = ghes_get_devices(); if (ghes_devs) return -ENODEV;
/* Continue init */
and then load in that case because user has disabled GHES and thus no ghes_edac either. So the platform-specific one loads.
Right?
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |