Messages in this thread | | | Date | Fri, 23 Sep 2022 14:12:24 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2 3/3] ARM: orion5x: Add D-Link DNS-323 based on Device Tree |
| |
> > > + if (of_machine_is_compatible("dlink,dns323a1")) { > > > + writel(0, MPP_DEV_CTRL); /* DEV_D[31:16] */ > > > > I spotted this in dns323-setup.c as well. Do you have any idea what it > > does? > > > > No idea. I have tried to replicate what was in dns323-setup.c as exactly as > possible. > I can try to leave it out and see if anything changes.
It is best to keep what we don't understand. It will be there for a reason.
Andrew
| |