lkml.org 
[lkml]   [2022]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 3/3] dmaengine: tegra: Add support for dma-channel-mask
From

On 23/09/2022 12:09, Akhil R wrote:

...

>> Ah OK. I was wondering how this worked with 'channel_reg_size' but
>> looking closer I see channel_reg_size is always SZ_64K. I wonder why we
>> even bother having this parameter and don't use SZ_64K directly?
> There is an offset from the base address which the per channel registers start.
> Although this offset value happens to match with the channel_reg_size, this is
> not actually the per channel register size.

Yes I see that, but I mean why do we even bother having this
channel_reg_size parameter? Does not look like we need this (currently).
All we need is ...

tdc->chan_base_offset = TEGRA_GPCDMA_CHANNEL_BASE_ADDR_OFFSET +
(i * SZ_64K);

Jon

--
nvpublic

\
 
 \ /
  Last update: 2022-09-23 13:46    [W:1.093 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site