Messages in this thread | | | From | Heiko Stuebner <> | Subject | Re: [PATCH V4 3/3] arch: crash: Remove duplicate declaration in smp.h | Date | Fri, 23 Sep 2022 13:00:32 +0200 |
| |
Am Mittwoch, 21. September 2022, 05:31:34 CEST schrieb guoren@kernel.org: > From: Guo Ren <guoren@linux.alibaba.com> > > Remove crash_smp_send_stop declarations in arm64, x86 asm/smp.h which > has been done in include/linux/smp.h.
nit: the commit message could reference the commit that brought in the generic declarations, which was 6f1f942cd5fb ("smp: kernel/panic.c - silence warnings")
other than that Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com> > Signed-off-by: Guo Ren <guoren@kernel.org> > Acked-by: Catalin Marinas <catalin.marinas@arm.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Thomas Gleixner <tglx@linutronix.de> > --- > arch/arm64/include/asm/smp.h | 1 - > arch/x86/include/asm/crash.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h > index fc55f5a57a06..a108ac93fd8f 100644 > --- a/arch/arm64/include/asm/smp.h > +++ b/arch/arm64/include/asm/smp.h > @@ -141,7 +141,6 @@ static inline void cpu_panic_kernel(void) > */ > bool cpus_are_stuck_in_kernel(void); > > -extern void crash_smp_send_stop(void); > extern bool smp_crash_stop_failed(void); > extern void panic_smp_self_stop(void); > > diff --git a/arch/x86/include/asm/crash.h b/arch/x86/include/asm/crash.h > index 8b6bd63530dc..6a9be4907c82 100644 > --- a/arch/x86/include/asm/crash.h > +++ b/arch/x86/include/asm/crash.h > @@ -7,6 +7,5 @@ struct kimage; > int crash_load_segments(struct kimage *image); > int crash_setup_memmap_entries(struct kimage *image, > struct boot_params *params); > -void crash_smp_send_stop(void); > > #endif /* _ASM_X86_CRASH_H */ >
| |