Messages in this thread | | | Date | Fri, 23 Sep 2022 12:42:14 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] ASoC: da7219: Fix an error handling path in da7219_register_dai_clks() |
| |
On Thu, Sep 22, 2022 at 09:44:57PM +0200, Christophe JAILLET wrote: > If clk_hw_register() fails, the corresponding clk should not be > unregistered. > > To handle errors from loops, clean up partial iterations before doing the > goto. So add a clk_hw_unregister(). > Then use a while (--i >= 0) loop in the unwind section. > > Fixes: 78013a1cf297 ("ASoC: da7219: Fix clock handling around codec level probe") > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > See https://lore.kernel.org/all/4fdde55198294a07f04933f7cef937fcb654c901.1624425670.git.christophe.jaillet@wanadoo.fr/ > for an incomplete patch sent last year and Dan's comment on it.
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |