Messages in this thread | | | Date | Fri, 23 Sep 2022 11:34:31 +0200 | Subject | Re: [PATCH] dt-bindings: usb: dwc3: Add interrupt-names to include hibernation interrupt | From | Michal Simek <> |
| |
Hi Krzysztof,
On 9/23/22 11:22, Krzysztof Kozlowski wrote: > On 23/09/2022 06:38, Mehta, Piyush wrote: >>> Thanks, >>> Michal >> >> Enabling wakeup in zynqMp we need to put the core into hibernation, as versal don't have hibernation concept, but we require interrupt for wakeup. >> We have a versal platform where we are not using hibernation, but system wake up we need the interrupt. For this interrupt-name enum would be: >> - enum [host, peripheral, otg, usb-wakeup] >> >> zynqMp : >> - enum [host, peripheral, otg, hiber] >> >> Versal: >> - enum [host, peripheral, otg, usb-wakeup] > > That's a different name you use now...
It is small confusion.
We have dwc3 in 3 SOCs. ZynqMP/Versal and Versal NET.
In ZynqMP currently we are define it as interrupt-names = "dwc_usb3", "otg", "hiber"; (https://github.com/Xilinx/u-boot-xlnx/blob/master/arch/arm/dts/zynqmp.dtsi#L996) where I think we should be able to convert it host, peripheral, otg, hiber
And Versal (Versal NET is the same as Versal) is now using interrupt-names = "dwc_usb3","otg","usb-wakeup"; https://github.com/Xilinx/u-boot-xlnx/blob/master/arch/arm/dts/versal.dtsi#L597
where it can be converted to host, peripheral, otg, usb-wakeup
but the last usb-wakeup entry is the problematic one. You mentioned before if this is SOC specific maybe we should consider to create new compatible string to match this.
Thanks, Michal
| |