lkml.org 
[lkml]   [2022]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 10/33] drm/modes: Add a function to generate analog display modes
Date
On Fri, 23 Sep 2022, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Am 22.09.22 um 16:25 schrieb Maxime Ripard:
>> + drm_dbg_kms(dev,
>> + "Generating a %ux%u%c, %u-line mode with a %lu kHz clock\n",
>> + hactive, vactive,
>> + interlace ? 'i' : 'p',
>> + params->num_lines,
>> + pixel_clock_hz / 1000);
>
> Divide by HZ_PER_KHZ here and in other places.
>
> https://elixir.bootlin.com/linux/latest/source/include/linux/units.h#L23

From the Department of Bikeshedding:

I find "pixel_clock_hz / 1000" has much more clarity than
"pixel_clock_hz / HZ_PER_KHZ".

I don't consider the SI prefixes magic numbers.


BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center

\
 
 \ /
  Last update: 2022-09-23 11:19    [W:0.092 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site