Messages in this thread | | | Subject | Re: [PATCH 1/9] Input: synaptics-rmi4 - fix firmware update operations with bootloader v8 | From | Matthias Schiffer <> | Date | Fri, 23 Sep 2022 11:12:25 +0200 |
| |
On Thu, 2022-09-22 at 16:06 -0400, Lyude Paul wrote: > Would add a Cc: stable@vger.kernel.org for this > > With that fixed: Reviewed-by: Lyude Paul <lyude@redhat.com>
Thanks for the review!
Should I reroll with the added Cc? In my experience, patches will end up queued for stable through AUTOSEL anyways as soon as the word "fix" appears somewhere in the commit message.
> > On Wed, 2022-06-08 at 14:48 +0200, Matthias Schiffer wrote: > > Commit a6977d758fed ("Input: synaptics-rmi4 - support bootloader v8 in > > f34v7") allowed the F34v7 driver to probe with bootloader v8, but it did > > not update various other bootloader version checks in the F34 code. > > > > Fixes: a6977d758fed ("Input: synaptics-rmi4 - support bootloader v8 in f34v7") > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> > > --- > > drivers/input/rmi4/rmi_f34.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/input/rmi4/rmi_f34.c b/drivers/input/rmi4/rmi_f34.c > > index e5dca9868f87..3afc94f679ed 100644 > > --- a/drivers/input/rmi4/rmi_f34.c > > +++ b/drivers/input/rmi4/rmi_f34.c > > @@ -370,7 +370,7 @@ static int rmi_firmware_update(struct rmi_driver_data *data, > > > > f34 = dev_get_drvdata(&data->f34_container->dev); > > > > - if (f34->bl_version == 7) { > > + if (f34->bl_version >= 7) { > > if (data->pdt_props & HAS_BSR) { > > dev_err(dev, "%s: LTS not supported\n", __func__); > > return -ENODEV; > > @@ -382,7 +382,7 @@ static int rmi_firmware_update(struct rmi_driver_data *data, > > } > > > > /* Enter flash mode */ > > - if (f34->bl_version == 7) > > + if (f34->bl_version >= 7) > > ret = rmi_f34v7_start_reflash(f34, fw); > > else > > ret = rmi_f34_enable_flash(f34); > > @@ -413,7 +413,7 @@ static int rmi_firmware_update(struct rmi_driver_data *data, > > f34 = dev_get_drvdata(&data->f34_container->dev); > > > > /* Perform firmware update */ > > - if (f34->bl_version == 7) > > + if (f34->bl_version >= 7) > > ret = rmi_f34v7_do_reflash(f34, fw); > > else > > ret = rmi_f34_update_firmware(f34, fw);
| |