Messages in this thread | | | Date | Thu, 22 Sep 2022 14:23:53 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v5 2/6] iommu/amd: Drop unnecessary checks in amd_iommu_attach_device() |
| |
On Thu, Sep 22, 2022 at 01:53:52AM -0700, Nicolin Chen wrote: > The same checks are done in amd_iommu_probe_device(). If any of them fails > there, then the device won't get a group, so there's no way for it to even > reach amd_iommu_attach_device anymore. > > Suggested-by: Robin Murphy <robin.murphy@arm.com> > Cc: Joerg Roedel <joro@8bytes.org> > Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> > Reviewed-by: Vasant Hegde <vasant.hegde@amd.com> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> > --- > drivers/iommu/amd/iommu.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
| |