lkml.org 
[lkml]   [2022]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel
From
On 22/09/2022 15:58, Konrad Dybcio wrote:
> Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2
> Compact smartphones.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Thank you for your patch. There is something to discuss/improve.

> +
> + reg: true
> +
> + backlight: true
> +
> + vddio-supply:
> + description: VDDIO 1.8V supply
> +
> + vsp-supply:
> + description: Positive 5.5V supply
> +
> + vsn-supply:
> + description: Negative 5.5V supply
> +
> + preset-gpios:

How about bringing them closer to common GPIOs:
panel-reset-gpios
?

> + description: Display panel reset pin
> +
> + treset-gpios:

touch-reset-gpios


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-22 17:12    [W:0.112 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site