Messages in this thread | | | Date | Thu, 22 Sep 2022 08:06:05 -0700 | From | Colin Foster <> | Subject | Re: [PATCH -next] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE |
| |
Hi Yang,
On Thu, Sep 22, 2022 at 06:37:03PM +0800, Yang Yingliang wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Fixes: f3e893626abe ("mfd: ocelot: Add support for the vsc7512 chip via spi") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/mfd/ocelot-spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/ocelot-spi.c b/drivers/mfd/ocelot-spi.c > index 0f097f4829d1..2ecd271de2fb 100644 > --- a/drivers/mfd/ocelot-spi.c > +++ b/drivers/mfd/ocelot-spi.c > @@ -276,6 +276,7 @@ static const struct spi_device_id ocelot_spi_ids[] = { > { "vsc7512", 0 }, > { } > }; > +MODULE_DEVICE_TABLE(spi, ocelot_spi_ids); > > static const struct of_device_id ocelot_spi_of_match[] = { > { .compatible = "mscc,vsc7512" }, > -- > 2.25.1 >
Good catch. I just tested running ocelot-soc as a module and it worked without your patch. Do you know how I can test the case where it fails?
Thanks
Colin Foster
| |