Messages in this thread | | | From | Guillaume Ranquet <> | Date | Thu, 22 Sep 2022 05:45:43 -0700 | Subject | Re: [PATCH v1 01/17] dt-bindings: clk: mediatek: Add MT8195 DPI clocks |
| |
On Thu, 22 Sep 2022 09:11, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: >On 19/09/2022 18:55, Guillaume Ranquet wrote: >> From: Pablo Sun <pablo.sun@mediatek.com> >> >> Expand dt-bindings slot for VDOSYS1 of MT8195. >> This clock is required by the DPI1 hardware >> and is a downstream of the HDMI pixel clock. >> >> Signed-off-by: Pablo Sun <pablo.sun@mediatek.com> >> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com> >> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> >> > >Looks like broken patch. > >Best regards, >Krzysztof >
Hi Bo-Chen and Krzysztof, I've sent the patches using the rather new b4 prep/send commands.
Though it produces valid patches, it's using `git show --format=email` to produce the patches, which lacks a diffstat.
My understanding is that the diffstat is considered to be comments and thus are not necessary to produce a valid patch.
I've reported the issue on the tools mailing list [1], I'm looking at providing a fix.
I'll be extra careful at the patch format for V2.
Sorry for the inconveniance, Guillaume.
[1] https://lore.kernel.org/tools/CABnWg9uBOGqJMq=yCtn7SoEME=+2u1-ZK9ftb6=_jRhkhL_jiw@mail.gmail.com/T/#u
| |