Messages in this thread | | | Date | Thu, 22 Sep 2022 10:40:32 +0100 | Subject | Re: [PATCH v6 00/21] x86/resctrl: Make resctrl_arch_rmid_read() return values in bytes | From | James Morse <> |
| |
Hello!
On 13/09/2022 02:00, tan.shaopeng@fujitsu.com wrote: >> Changes in this version? >> * Changed supports_mba_mbps() to use is_mbm_local_enabled() >> >> --- >> The aim of this series is to insert a split between the parts of the monitor code >> that the architecture must implement, and those that are part of the resctrl >> filesystem. The eventual aim is to move all filesystem parts out to live in >> /fs/resctrl, so that resctrl can be wired up for MPAM. >> >> What's MPAM? See the cover letter of a previous series. [1] >> >> The series adds domain online/offline callbacks to allow the filesystem to >> manage some of its structures itself, then moves all the 'mba_sc' behaviour to >> be part of the filesystem. >> This means another architecture doesn't need to provide an mbps_val array. >> As its all software, the resctrl filesystem should be able to do this without any >> help from the architecture code. >> >> Finally __rmid_read() is refactored to be the API call that the architecture >> provides to read a counter value. All the hardware specific overflow detection, >> scaling and value correction should occur behind this helper.
> I tested this patch series(patch v6) on Intel(R) Xeon(R) Gold 6254 CPU with resctrl selftest. > It is no problem. > > Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com> > Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
Thanks for testing it again!
James
| |