Messages in this thread | | | Subject | Re: Linux 4.14.294 | From | Joe Perches <> | Date | Thu, 22 Sep 2022 01:39:28 -0700 |
| |
On Thu, 2022-09-22 at 10:32 +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 22, 2022 at 01:26:59AM -0700, Joe Perches wrote: > > On Thu, 2022-09-22 at 08:53 +0200, Greg Kroah-Hartman wrote: > > > On Thu, Sep 22, 2022 at 11:02:21AM +0700, Bagas Sanjaya wrote: > > > > On 9/22/22 01:03, Joe Perches wrote: > > > > > On Tue, 2022-09-20 at 12:17 +0200, Greg Kroah-Hartman wrote: > > > > > [] > > > > > > diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h > > > > > [] > > > > > > @@ -118,7 +118,7 @@ struct report_list { > > > > > > * @multi_packet_cnt: Count of fragmented packet count > > > > > > * > > > > > > * This structure is used to store completion flags and per client data like > > > > > > - * like report description, number of HID devices etc. > > > > > > + * report description, number of HID devices etc. > > > > > > */ > > > > > > struct ishtp_cl_data { > > > > > > /* completion flags */ > > > > > > > > > > Needless backporting of typo fixes reduces confidence in the > > > > > backport process. > > > > > > > > > > > > > The upstream commit 94553f8a218540 ("HID: ishtp-hid-clientHID: ishtp-hid-client: > > > > Fix comment typo") didn't Cc: stable, but got AUTOSELed [1]. > > > > > > > > I think we should only AUTOSEL patches that have explicit Cc: stable. > > > > > > That's not how AUTOSEL works or why it is there at all, sorry. > > > > Perhaps not, but why is AUTOSEL choosing this and why is > > this being applied without apparent human review? > > We always appreciate more review, and welcome it. Sometimes things slip > by us as well, like it did for this one. The changelog makes it look > like a real fix that is needed.
What part of:
-------------------------- commit 94553f8a218540d676efbf3f7827ed493d1057cf Author: Jason Wang <wangborong@cdjrlc.com> Date: Thu Aug 4 08:58:14 2022 +0800
HID: ishtp-hid-clientHID: ishtp-hid-client: Fix comment typo The double `like' is duplicated in the comment, remove one. Signed-off-by: Jason Wang <wangborong@cdjrlc.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> --------------------------
makes it seem like a candidate for backporting?
Perhaps the eagerness to backport is simply too high.
| |