lkml.org 
[lkml]   [2022]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/5] elevator: remove redundant code in elv_unregister_queue()
On Thu, Sep 22, 2022 at 07:35:58PM +0800, Yu Kuai wrote:
> "elevator_queue *e" is already declared and initialized in the beginning
> of elv_unregister_queue().
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> block/elevator.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/block/elevator.c b/block/elevator.c
> index 7cb61820cfa0..0a72d6fbbdcc 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -524,8 +524,6 @@ void elv_unregister_queue(struct request_queue *q)
> lockdep_assert_held(&q->sysfs_lock);
>
> if (e && test_and_clear_bit(ELEVATOR_FLAG_REGISTERED, &e->flags)) {
> - struct elevator_queue *e = q->elevator;
> -
> kobject_uevent(&e->kobj, KOBJ_REMOVE);
> kobject_del(&e->kobj);
> }
> --

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric

\
 
 \ /
  Last update: 2022-09-23 05:38    [W:0.227 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site