Messages in this thread | | | Date | Thu, 22 Sep 2022 20:37:08 -0700 | From | Eric Biggers <> | Subject | Re: [PATCH v3 5/5] elevator: remove redundant code in elv_unregister_queue() |
| |
On Thu, Sep 22, 2022 at 07:35:58PM +0800, Yu Kuai wrote: > "elevator_queue *e" is already declared and initialized in the beginning > of elv_unregister_queue(). > > Signed-off-by: Yu Kuai <yukuai3@huawei.com> > --- > block/elevator.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/block/elevator.c b/block/elevator.c > index 7cb61820cfa0..0a72d6fbbdcc 100644 > --- a/block/elevator.c > +++ b/block/elevator.c > @@ -524,8 +524,6 @@ void elv_unregister_queue(struct request_queue *q) > lockdep_assert_held(&q->sysfs_lock); > > if (e && test_and_clear_bit(ELEVATOR_FLAG_REGISTERED, &e->flags)) { > - struct elevator_queue *e = q->elevator; > - > kobject_uevent(&e->kobj, KOBJ_REMOVE); > kobject_del(&e->kobj); > } > --
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
| |