Messages in this thread | | | Date | Thu, 22 Sep 2022 17:02:04 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v3 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled |
| |
On Thu, 15 Sep 2022 21:32:59 -0400 "Martin K. Petersen" <martin.petersen@oracle.com> wrote:
> Steven, > > Can you please review Arun's patch?
Sorry, was busy running a conference ;-)
> > > Fix this compilation error seen when CONFIG_TRACING is not enabled: > > > > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init': > > drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function > > 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? > > [-Werror=implicit-function-declaration] > > 2854 | qla_trc_array = trace_array_get_by_name("qla2xxx"); > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > | trace_array_set_clr_event > > > > drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit': > > drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function > > 'trace_array_put' [-Werror=implicit-function-declaration] > > 2869 | trace_array_put(qla_trc_array); > > | ^~~~~~~~~~~~~~~ > > >
The patch looks good to me.
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
| |