lkml.org 
[lkml]   [2022]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] ACPI: PCC: replace wait_for_completion()
On Tue, Sep 20, 2022 at 05:44:59PM +0800, Huisong Li wrote:
> Currently, the function waiting for completion of mailbox operation is
> 'wait_for_completion()'. The PCC method will be permanently blocked if
> this mailbox message fails to execute. So this patch replaces it with
> 'wait_for_completion_timeout()'. And set the timeout interval to an
> arbitrary retries on top of nominal to prevent the remote processor is
> slow to respond to PCC commands.
>

Sounds good to me. The only concern(may be not serious) is what happens
if we receive response from the platform after the timeout. I have tested
for that in non ACPI non PCC context. I don't have a setup to trigger that
with ACPI PCC + this patch to test. Other than that, I am fine with this:

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

--
Regards,
Sudeep

\
 
 \ /
  Last update: 2022-09-21 17:50    [W:0.199 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site