lkml.org 
[lkml]   [2022]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] ASoC: wcd9335: fix order of Slimbus unprepare/disable
From


On 9/21/22 17:08, Krzysztof Kozlowski wrote:
> On 21/09/2022 17:06, Krzysztof Kozlowski wrote:
>> On 21/09/2022 17:05, Pierre-Louis Bossart wrote:
>>>> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
>>>> index 06c6adbe5920..d2548fdf9ae5 100644
>>>> --- a/sound/soc/codecs/wcd9335.c
>>>> +++ b/sound/soc/codecs/wcd9335.c
>>>> @@ -1972,8 +1972,8 @@ static int wcd9335_trigger(struct snd_pcm_substream *substream, int cmd,
>>>> case SNDRV_PCM_TRIGGER_STOP:
>>>> case SNDRV_PCM_TRIGGER_SUSPEND:
>>>> case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>>> - slim_stream_unprepare(dai_data->sruntime);
>>>> slim_stream_disable(dai_data->sruntime);
>>>> + slim_stream_unprepare(dai_data->sruntime);
>>>
>>> This looks logical but different from what the kernel doc says:
>>>
>>> /**
>>> * slim_stream_disable() - Disable a SLIMbus Stream
>>> *
>>> * @stream: instance of slim stream runtime to disable
>>> *
>>> * This API will disable all the ports and channels associated with
>>> * SLIMbus stream
>>> *
>>> * Return: zero on success and error code on failure. From ASoC DPCM
>>> framework,
>>> * this state is linked to trigger() pause operation.
>>> */
>>>
>>> /**
>>> * slim_stream_unprepare() - Un-prepare a SLIMbus Stream
>>> *
>>> * @stream: instance of slim stream runtime to unprepare
>>> *
>>> * This API will un allocate all the ports and channels associated with
>>> * SLIMbus stream
>>
>> You mean this piece of doc? Indeed looks inaccurate. I'll update it.
>
> Wait, no, this is correct. Please point to what is wrong in kernel doc.
> I don't see it. :(

the TRIGGER_STOP and TRIGGER_PAUSE_PUSH do the same thing. There is no
specific mapping of disable() to TRIGGER_STOP and unprepare() to
TRIGGER_PAUSE_PUSH as the documentation hints at.

\
 
 \ /
  Last update: 2022-09-21 17:12    [W:0.056 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site