lkml.org 
[lkml]   [2022]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 4/4] arm: dts: imx7-colibri: remove spurious debounce property
+Greg, to get an opinion on the fixes tag.

On Tue, Sep 20, 2022 at 11:22:27AM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Remove spurious debounce property from linux,extcon-usb-gpio.
>
> Note that debouncing is hard-coded to 20 ms (USB_GPIO_DEBOUNCE_MS
> define).
>
> Fixes: 0ef1969ea569 ("ARM: dts: imx7-colibri: move aliases, chosen, extcon and gpio-keys")
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Hello all,
we did have some (internal) discussion if this patch should have the
fixes tag or not.

I do personally think it should not have it and should not be backported
to stable tree, since this is not fixing a real bug, it's just a
cleanup.

On the other hand the original patch was not correct, and this change is
making it right.

What is the general opinion on this topic? What do the stable kernel
maintainers would expect?

Documentation/process/stable-kernel-rules.rst is about rules for
backporting, it does not really talk about the fixes tag, but today this
is used to decide if a patch should be backported or not.

Francesco

\
 
 \ /
  Last update: 2022-09-21 14:15    [W:0.056 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site