Messages in this thread | | | From | Rasmus Villemoes <> | Subject | [PATCH v2 0/9] rtc: isl12022: cleanups and hwmon support | Date | Wed, 21 Sep 2022 13:46:15 +0200 |
| |
This series does a few cleanups of the isl12022 driver,
- removes use of deprecated function - removes some redundant code - switches to regmap API instead of private helpers
It also provides range_min, range_max values and finally hooks up the temperatur sensor to hwmon.
Changes in v2:
- Use devm_hwmon_device_register_with_info() (Guenter), and use the opportunity to also expose an update_interval with the constant value 60000.
- Convert some dev_dbgs to use %ptR, remove a dev_info() (Alexandre)
- Add patch setting range_min, range_max (Alexandre)
Not changed in v2: For now, I've kept the low-battery dev_warn(). Implementing support for the ioctls RTC_VL_READ/RTC_VL_CLR is on my radar, but I will need some more time for reading up on and deciding on the details of what the chip provides and how to map that information to the various defined RTC_VL_* bits. I also need to figure out a good way to reliably trigger a low-battery condition so I can test the ioctl support. So I hope these patches can go in for now and not be blocked on the series expanding even further.
Rasmus Villemoes (9): rtc: isl12022: stop using deprecated devm_rtc_device_register() rtc: isl12022: specify range_min and range_max rtc: isl12022: drop a dev_info() rtc: isl12022: simplify some expressions rtc: isl12022: use %ptR rtc: isl12022: use dev_set_drvdata() instead of i2c_set_clientdata() rtc: isl12022: drop redundant write to HR register rtc: isl12022: switch to using regmap API rtc: isl12022: add support for temperature sensor
drivers/rtc/Kconfig | 1 + drivers/rtc/rtc-isl12022.c | 237 ++++++++++++++++++++----------------- 2 files changed, 131 insertions(+), 107 deletions(-)
-- 2.37.2
| |