lkml.org 
[lkml]   [2022]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v6 5/7] ethtool: add interface to interact with Ethernet Power Equipment
On Wed, Sep 21, 2022 at 02:47:45PM +0200, Oleksij Rempel wrote:
> +PSE_GET
> +=======
> +
> +Gets PSE attributes.
> +
> +Request contents:
> +
> + ===================================== ====== ==========================
> + ``ETHTOOL_A_PSE_HEADER`` nested request header
> + ===================================== ====== ==========================
> +
> +Kernel response contents:
> +
> + ====================================== ====== =============================
> + ``ETHTOOL_A_PSE_HEADER`` nested reply header
> + ``ETHTOOL_A_PODL_PSE_ADMIN_STATE`` u32 Operational state of the PoDL
> + PSE functions
> + ``ETHTOOL_A_PODL_PSE_PW_D_STATUS`` u32 power detection status of the
> + PoDL PSE.
> + ====================================== ====== =============================
> +
> +When set, the optional ``ETHTOOL_A_PODL_PSE_ADMIN_STATE`` attribute identifies
> +the operational state of the PoDL PSE functions. The operational state of the
> +PSE function can be changed using the ``ETHTOOL_A_PODL_PSE_ADMIN_CONTROL``
> +action. This option is corresponding to IEEE 802.3-2018 30.15.1.1.2
> +aPoDLPSEAdminState. Possible values are:

The IEEE 802.3-2018 keyword name can be enclosed within inline code block.

> +When set, the optional ``ETHTOOL_A_PODL_PSE_PW_D_STATUS`` attribute identifies
> +the power detection status of the PoDL PSE. The status depend on internal PSE
> +state machine and automatic PD classification support. This option is
> +corresponding to IEEE 802.3-2018 30.15.1.1.3 aPoDLPSEPowerDetectionStatus.

Same here.

> +When set, the optional ``ETHTOOL_A_PODL_PSE_ADMIN_CONTROL`` attribute is used
> +to control PoDL PSE Admin functions. This option is implementing
> +IEEE 802.3-2018 30.15.1.2.1 acPoDLPSEAdminControl. See

Same here too.

Otherwise LGTM.

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

--
An old man doll... just what I always wanted! - Clara
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-09-22 05:37    [W:0.150 / U:0.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site