Messages in this thread | | | From | Andrii Nakryiko <> | Date | Wed, 21 Sep 2022 17:38:10 -0700 | Subject | Re: [bpf-next v3 2/2] selftests/bpf: Add testcases for pinning to errpath |
| |
On Sun, Sep 18, 2022 at 7:28 PM Wang Yufen <wangyufen@huawei.com> wrote: > > Add testcases for map and prog pin to errpath. > > Signed-off-by: Wang Yufen <wangyufen@huawei.com> > ---
let's drop this selftest, it does global system manipulations just to check those two if conditions inside pathname_concat(), probably not worth it.
Also for the future, we shouldn't use CHECK() in new selftests (we still have CHECK()s because there are like 2 thousand of them in old selftest, so clean up is not trivial).
> tools/testing/selftests/bpf/prog_tests/pinning.c | 67 ++++++++++++++++++++++ > .../selftests/bpf/progs/test_pinning_path.c | 19 ++++++ > 2 files changed, 86 insertions(+) > create mode 100644 tools/testing/selftests/bpf/progs/test_pinning_path.c >
[...]
| |