Messages in this thread | | | Date | Wed, 21 Sep 2022 09:20:43 +0200 | Subject | Re: [PATCH 1/4] dt-bindings: pinctrl: Combine MediaTek MT67xx pinctrl binding docs | From | Krzysztof Kozlowski <> |
| |
On 19/09/2022 19:01, Yassine Oudjana wrote: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Documents for MT6779, MT6795 and MT6797 that currently exist share > most properties, and each one has slightly differently worded > descriptions for those properties. Combine all three documents into > one common document for all MT67xx SoC pin controllers, picking a few > parts from each and accounting for differences such as items in reg > and reg-names properties. Also document the MT6765 pin controller > which currently has a driver but no DT binding documentation. It should > be possible to also include bindings for MT8183 and MT8188, but these > have some additional properties that might complicate things a bit, > so they are left alone for now. >
> properties: > compatible: > - const: mediatek,mt6795-pinctrl > + oneOf: > + - enum: > + - mediatek,mt6765-pinctrl > + - mediatek,mt6795-pinctrl > + - mediatek,mt6797-pinctrl > + - items: > + - const: mediatek,mt6779-pinctrl > + - const: syscon
No, this is not like old bindings at all. It's not merging, it's a change sneaked inside huge diff. Also - probably totally untested on DTS (or old bindings were broken).
That's a no-go.
Best regards, Krzysztof
| |