Messages in this thread | | | Date | Wed, 21 Sep 2022 22:10:45 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v5 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq |
| |
On Wed, Sep 21, 2022 at 09:51:59AM -0600, Raul E Rangel wrote: > Device tree already has a mechanism to pass the wake_irq. It does this > by looking for the wakeup-source property and setting the > I2C_CLIENT_WAKE flag. This CL adds the ACPI equivalent. It uses the > ACPI interrupt wake flag to determine if the interrupt can be used to > wake the system. Previously the i2c drivers had to make assumptions and > blindly enable the wake IRQ. This can cause spurious wake events. e.g., > If there is a device with an Active Low interrupt and the device gets > powered off while suspending, the interrupt line will go low since it's > no longer powered and wakes the system. For this reason we should > respect the board designers wishes and honor the wake bit defined on the > interrupt. > > Signed-off-by: Raul E Rangel <rrangel@chromium.org> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >
Acked-by: Wolfram Sang <wsa@kernel.org>
[unhandled content-type:application/pgp-signature] | |