Messages in this thread | | | Date | Wed, 21 Sep 2022 20:58:26 +0200 | Subject | Re: [PATCH v2 2/4] media: dt-bindings: Document Renesas RZ/G2L CRU block | From | Krzysztof Kozlowski <> |
| |
On 21/09/2022 19:29, Laurent Pinchart wrote: >>>>> + clock-names: >>>>> + items: >>>>> + - const: vclk >>>>> + - const: pclk >>>>> + - const: aclk >>>> >>>> Drop the "clk" suffixes. Remaining names could be made a bit more readable. >>> >>> These names come from the documentation, isn't it better to match the >>> datasheet ? >> >> If datasheet calls it "vclk_really_clk_it_is_clk_clk", it's not the >> reason to use it. :) >> >> The "clk" is redundant even if the hardware engineer thought different. >> >> The same for IRQs ("tx" not "txirq"), for dmas ("tx" not "txdma"). > > I'd argue that naming clocks "v", "p" and "a" would be less readable and > more confusing. Is this a new rule ?
Not really, but also it's only a style issue.
Indeed "v" and "p" are not much better... but still "vclk" does not bring any additional information over "v". It's redundant.
You can also drop entire entry - unless it helps in particular implementation.
https://lore.kernel.org/all/20220517175958.GA1321687-robh@kernel.org/ https://lore.kernel.org/all/20210815133926.22860-1-biju.das.jz@bp.renesas.com/ https://lore.kernel.org/all/YYFCaHI%2FDASUz+Vu@robh.at.kernel.org/ https://lore.kernel.org/all/20220830182540.GA1797396-robh@kernel.org/
Best regards, Krzysztof
| |