lkml.org 
[lkml]   [2022]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 8/8] kallsyms: Add self-test facility
From
Date


On 2022/9/20 11:14, kernel test robot wrote:
> Hi Zhen,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on mcgrof/modules-next]
> [also build test WARNING on linus/master v6.0-rc6 next-20220919]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Zhen-Lei/kallsyms-Optimizes-the-performance-of-lookup-symbols/20220919-231916
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next
> config: i386-randconfig-a001-20220919 (https://download.01.org/0day-ci/archive/20220920/202209201123.hihIfjo1-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/26fdb8f3984ffbdb57da2d1fac7e32ae418bfa96
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Zhen-Lei/kallsyms-Optimizes-the-performance-of-lookup-symbols/20220919-231916
> git checkout 26fdb8f3984ffbdb57da2d1fac7e32ae418bfa96
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> kernel/kallsyms.c:196:15: warning: no previous prototype for function 'kallsyms_sym_address' [-Wmissing-prototypes]
> unsigned long kallsyms_sym_address(int idx)
> ^
> kernel/kallsyms.c:196:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> unsigned long kallsyms_sym_address(int idx)
> ^

Well, thanks. Because it's just for testing code, I'm thinking about not
changing the header file, but it looks like I'll have to change it.

> static
> kernel/kallsyms.c:668:12: warning: no previous prototype for function 'arch_get_kallsym' [-Wmissing-prototypes]
> int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
> ^
> kernel/kallsyms.c:668:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
> ^
> static
> 2 warnings generated.
>
>
> vim +/kallsyms_sym_address +196 kernel/kallsyms.c
>
> 195
> > 196 unsigned long kallsyms_sym_address(int idx)
> 197 {
> 198 if (!IS_ENABLED(CONFIG_KALLSYMS_BASE_RELATIVE))
> 199 return kallsyms_addresses[idx];
> 200
> 201 /* values are unsigned offsets if --absolute-percpu is not in effect */
> 202 if (!IS_ENABLED(CONFIG_KALLSYMS_ABSOLUTE_PERCPU))
> 203 return kallsyms_relative_base + (u32)kallsyms_offsets[idx];
> 204
> 205 /* ...otherwise, positive offsets are absolute values */
> 206 if (kallsyms_offsets[idx] >= 0)
> 207 return kallsyms_offsets[idx];
> 208
> 209 /* ...and negative offsets are relative to kallsyms_relative_base - 1 */
> 210 return kallsyms_relative_base - 1 - kallsyms_offsets[idx];
> 211 }
> 212
>

--
Regards,
Zhen Lei

\
 
 \ /
  Last update: 2022-09-20 08:14    [W:0.053 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site