Messages in this thread | | | Date | Tue, 20 Sep 2022 16:04:00 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH Part2 v6 11/49] crypto:ccp: Define the SEV-SNP commands |
| |
On Tue, Sep 20, 2022 at 01:46:25PM +0000, Kalra, Ashish wrote: > These are structure definitions as per SNP Firmware API > specifications, and they match the SNP Firmware commands and required > arguments.
Yes, I have the spec.
> Isn't it better to have 1:1 mapping between specification and > structure definitions here ?
Why would it be better if you can have a single struct serving multiple purposes and thus less code to stare at and deal with?
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |