lkml.org 
[lkml]   [2022]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada 38x platforms
> +	if (of_device_is_compatible(np, "marvell,armada-380-audio")) {
> + err = armada_38x_i2s_init_quirk(pdev, priv, soc_dai);
> + /* Set initial pll frequency */
> + if (priv->pll_config)
> + armada_38x_set_pll(priv->pll_config, 44100);
> + if (err < 0)
> + return err;

A nitpick: It would be better to do the test for err before calling
armada_38x_set_pll(), and then there is no need for the NULL check.

Andrew

\
 
 \ /
  Last update: 2022-09-20 15:40    [W:0.100 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site