Messages in this thread | | | Date | Tue, 20 Sep 2022 06:33:03 -0700 | Subject | Re: [PATCH v2 7/8] kbuild: use obj-y instead extra-y for objects placed at the head | From | Guenter Roeck <> |
| |
On 9/19/22 23:56, Geert Uytterhoeven wrote: > Hi Günter, > > On Tue, Sep 20, 2022 at 12:59 AM Guenter Roeck <linux@roeck-us.net> wrote: >> On Tue, Sep 06, 2022 at 03:13:12PM +0900, Masahiro Yamada wrote: >>> The objects placed at the head of vmlinux need special treatments: >>> >>> - arch/$(SRCARCH)/Makefile adds them to head-y in order to place >>> them before other archives in the linker command line. >>> >>> - arch/$(SRCARCH)/kernel/Makefile adds them to extra-y instead of >>> obj-y to avoid them going into built-in.a. >>> >>> This commit gets rid of the latter. >>> >>> Create vmlinux.a to collect all the objects that are unconditionally >>> linked to vmlinux. The objects listed in head-y are moved to the head >>> of vmlinux.a by using 'ar m'. >>> >>> With this, arch/$(SRCARCH)/kernel/Makefile can consistently use obj-y >>> for builtin objects. >>> >>> There is no *.o that is directly linked to vmlinux. Drop unneeded code >>> in scripts/clang-tools/gen_compile_commands.py. >>> >>> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> >>> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> > > Where does this R-b come from? It was not present in Yamada-san's > posting. Added by b4? >
Maybe added by patchwork ? That is where I picked up the mbox.
Guenter
>> The following build failure is seen when building m68k:defconfig in >> next-20220919. > > [...] > >> # first bad commit: [6676e2cdd7c339dc40331faccbaac1112d2c1d78] kbuild: use obj-y instead extra-y for objects placed at the head > > I did provide my R-b on Yamada-san's fix for this issue, which was > sent later in this thread. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |