Messages in this thread | | | Subject | Re: [PATCH] scsi: ufs: Remove redundant function definitions from ufshcd.h | From | Bean Huo <> | Date | Tue, 20 Sep 2022 11:06:44 +0200 |
| |
Hi, Arthur,
On Mon, 2022-09-19 at 11:21 +0300, Arthur Simchaev wrote: > This patch removes Query-Request API functions declaration from > from include/ufs/ufshcd.h. Those declarations belongs solely to ^ unnecessary "from" ^belong
> ufs core privet header. > > Signed-off-by: Arthur Simchaev <Arthur.Simchaev@wdc.com> > --- > drivers/ufs/core/ufshcd-priv.h | 5 +++++ > include/ufs/ufshcd.h | 19 +------------------ > 2 files changed, 6 insertions(+), 18 deletions(-) > > diff --git a/drivers/ufs/core/ufshcd-priv.h > b/drivers/ufs/core/ufshcd-priv.h > index d00dba1..f68ca33 100644 > --- a/drivers/ufs/core/ufshcd-priv.h > +++ b/drivers/ufs/core/ufshcd-priv.h > @@ -42,6 +42,11 @@ static inline void ufs_hwmon_remove(struct ufs_hba > *hba) {} > static inline void ufs_hwmon_notify_event(struct ufs_hba *hba, u8 > ee_mask) {} > #endif > > +int ufshcd_query_descriptor_retry(struct ufs_hba *hba, > + enum query_opcode opcode, > + enum desc_idn idn, u8 index, > + u8 selector, > + u8 *desc_buf, int *buf_len); > int ufshcd_read_desc_param(struct ufs_hba *hba, > enum desc_idn desc_id, > int desc_index, > diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h > index 24c97e0..3647a71 100644 > --- a/include/ufs/ufshcd.h > +++ b/include/ufs/ufshcd.h > @@ -1176,24 +1176,7 @@ static inline int > ufshcd_disable_host_tx_lcc(struct ufs_hba *hba) > } > > /* Expose Query-Request API */ This comment should be removed, too?
Reviewed-by: Bean Huo <beanhuo@micron.com>
Kind regards, Bean
| |