Messages in this thread | | | From | Dexuan Cui <> | Subject | RE: [Patch v5 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter | Date | Tue, 20 Sep 2022 17:54:19 +0000 |
| |
> From: longli@linuxonhyperv.com <longli@linuxonhyperv.com> > Sent: Tuesday, August 30, 2022 5:35 PM > To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang > ... > From: Long Li <longli@microsoft.com> > > Add a RDMA VF driver for Microsoft Azure Network Adapter (MANA). > > Signed-off-by: Long Li <longli@microsoft.com> > ...
Reviewed-by: Dexuan Cui <decui@microsoft.com>
The patch looks good to me. Just a few small nitpicks (see the below).
> +static int mana_ib_probe(struct auxiliary_device *adev, > + const struct auxiliary_device_id *id) > +{ > + struct mana_adev *madev = container_of(adev, struct mana_adev, adev); > + struct gdma_dev *mdev = madev->mdev; > + struct mana_context *mc; > + struct mana_ib_dev *dev; > + int ret = 0;
Small nitpick: the 'ret' doesn't have to be initialized to 0.
> +int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct > ib_umem *umem, > + mana_handle_t *gdma_region, u64 page_sz) > +{ > ... > + > +if (!err) > + return 0;
Please add a Tab character to the above 2 lines.
| |