lkml.org 
[lkml]   [2022]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/14] misc: fastrpc: Use fastrpc_map_put in fastrpc_map_create on fail
    Date
    Move the kref_init right after the allocation so that we can use
    fastrpc_map_put on any following error case.

    Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
    ---
    drivers/misc/fastrpc.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
    index 6730aa324e10..5eececd9b6bd 100644
    --- a/drivers/misc/fastrpc.c
    +++ b/drivers/misc/fastrpc.c
    @@ -745,6 +745,8 @@ static int fastrpc_map_create(struct fastrpc_user *fl, int fd,
    return -ENOMEM;

    INIT_LIST_HEAD(&map->node);
    + kref_init(&map->refcount);
    +
    map->fl = fl;
    map->fd = fd;
    map->buf = dma_buf_get(fd);
    @@ -771,7 +773,6 @@ static int fastrpc_map_create(struct fastrpc_user *fl, int fd,
    map->size = len;
    map->va = sg_virt(map->table->sgl);
    map->len = len;
    - kref_init(&map->refcount);

    if (attr & FASTRPC_ATTR_SECUREMAP) {
    /*
    @@ -801,7 +802,7 @@ static int fastrpc_map_create(struct fastrpc_user *fl, int fd,
    attach_err:
    dma_buf_put(map->buf);
    get_err:
    - kfree(map);
    + fastrpc_map_put(map);

    return err;
    }
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-09-02 15:55    [W:5.103 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site