lkml.org 
[lkml]   [2022]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 46/72] ksmbd: return STATUS_BAD_NETWORK_NAME error status if share is not configured
    Date
    From: Namjae Jeon <linkinjeon@kernel.org>

    [ Upstream commit fe54833dc8d97ef387e86f7c80537d51c503ca75 ]

    If share is not configured in smb.conf, smb2 tree connect should return
    STATUS_BAD_NETWORK_NAME instead of STATUS_BAD_NETWORK_PATH.

    Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
    Reviewed-by: Hyunchul Lee <hyc.lee@gmail.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/ksmbd/mgmt/tree_connect.c | 2 +-
    fs/ksmbd/smb2pdu.c | 3 ++-
    2 files changed, 3 insertions(+), 2 deletions(-)

    diff --git a/fs/ksmbd/mgmt/tree_connect.c b/fs/ksmbd/mgmt/tree_connect.c
    index 0d28e723a28c7..940385c6a9135 100644
    --- a/fs/ksmbd/mgmt/tree_connect.c
    +++ b/fs/ksmbd/mgmt/tree_connect.c
    @@ -18,7 +18,7 @@
    struct ksmbd_tree_conn_status
    ksmbd_tree_conn_connect(struct ksmbd_session *sess, char *share_name)
    {
    - struct ksmbd_tree_conn_status status = {-EINVAL, NULL};
    + struct ksmbd_tree_conn_status status = {-ENOENT, NULL};
    struct ksmbd_tree_connect_response *resp = NULL;
    struct ksmbd_share_config *sc;
    struct ksmbd_tree_connect *tree_conn = NULL;
    diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
    index a9c33d15ca1fb..bbb3958b6469d 100644
    --- a/fs/ksmbd/smb2pdu.c
    +++ b/fs/ksmbd/smb2pdu.c
    @@ -1930,8 +1930,9 @@ int smb2_tree_connect(struct ksmbd_work *work)
    rsp->hdr.Status = STATUS_SUCCESS;
    rc = 0;
    break;
    + case -ENOENT:
    case KSMBD_TREE_CONN_STATUS_NO_SHARE:
    - rsp->hdr.Status = STATUS_BAD_NETWORK_PATH;
    + rsp->hdr.Status = STATUS_BAD_NETWORK_NAME;
    break;
    case -ENOMEM:
    case KSMBD_TREE_CONN_STATUS_NOMEM:
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-02 14:56    [W:4.297 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site