lkml.org 
[lkml]   [2022]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 56/77] media: pvrusb2: fix memory leak in pvr_probe
    Date
    From: Dongliang Mu <mudongliangabcd@gmail.com>

    commit 945a9a8e448b65bec055d37eba58f711b39f66f0 upstream.

    The error handling code in pvr2_hdw_create forgets to unregister the
    v4l2 device. When pvr2_hdw_create returns back to pvr2_context_create,
    it calls pvr2_context_destroy to destroy context, but mp->hdw is NULL,
    which leads to that pvr2_hdw_destroy directly returns.

    Fix this by adding v4l2_device_unregister to decrease the refcount of
    usb interface.

    Reported-by: syzbot+77b432d57c4791183ed4@syzkaller.appspotmail.com
    Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
    +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
    @@ -2611,6 +2611,7 @@ struct pvr2_hdw *pvr2_hdw_create(struct
    del_timer_sync(&hdw->encoder_run_timer);
    del_timer_sync(&hdw->encoder_wait_timer);
    flush_work(&hdw->workpoll);
    + v4l2_device_unregister(&hdw->v4l2_dev);
    usb_free_urb(hdw->ctl_read_urb);
    usb_free_urb(hdw->ctl_write_urb);
    kfree(hdw->ctl_read_buffer);

    \
     
     \ /
      Last update: 2022-09-02 14:41    [W:5.224 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site