Messages in this thread | | | Date | Fri, 2 Sep 2022 13:51:25 +0200 | Subject | Re: [PATCH v3 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize_input() | From | Cezary Rojewski <> |
| |
On 2022-09-01 9:38 PM, Andy Shevchenko wrote: > On Thu, Sep 1, 2022 at 8:40 PM Cezary Rojewski > <cezary.rojewski@intel.com> wrote: >> >> Make use of global user input tokenization helper instead of the >> internal one as both serve same purpose. With that, both strsplit_u32() > > the same > >> and tokenize_input() become unused so remove them.
...
>> #include <linux/debugfs.h> >> #include <linux/module.h> >> #include <linux/pm_runtime.h> >> +#include <linux/string_helpers.h> > > I believe either blank line needs to be here (to split the sound / SOF > group of headers) or this should be put after 'so*'-ones
Newline it is then.
>> #include <sound/soc.h> >> #include <sound/sof/header.h> >> #include "sof-client.h"
...
>> struct sof_probes_priv *priv = cdev->data; >> struct device *dev = &cdev->auxdev.dev; >> struct sof_probe_point_desc *desc; >> - size_t num_tkns, bytes; >> - u32 *tkns; >> + size_t bytes; >> + u32 num_tkns, *tkns; > > I would expect a longer line first.
Ack.
> With the above addressed > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> >
| |