Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] powerpc/papr_scm: Ensure rc is always initialized in papr_scm_pmu_register() | Date | Fri, 02 Sep 2022 21:30:52 +1000 |
| |
On Tue, 30 Aug 2022 08:12:56 -0700, Nathan Chancellor wrote: > Clang warns: > > arch/powerpc/platforms/pseries/papr_scm.c:492:6: warning: variable 'rc' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > if (!p->stat_buffer_len) > ^~~~~~~~~~~~~~~~~~~ > arch/powerpc/platforms/pseries/papr_scm.c:523:64: note: uninitialized use occurs here > dev_info(&p->pdev->dev, "nvdimm pmu didn't register rc=%d\n", rc); > ^~ > include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info' > dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), ##__VA_ARGS__) > ^~~~~~~~~~~ > include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap' > _p_func(dev, fmt, ##__VA_ARGS__); \ > ^~~~~~~~~~~ > arch/powerpc/platforms/pseries/papr_scm.c:492:2: note: remove the 'if' if its condition is always false > if (!p->stat_buffer_len) > ^~~~~~~~~~~~~~~~~~~~~~~~ > arch/powerpc/platforms/pseries/papr_scm.c:484:8: note: initialize the variable 'rc' to silence this warning > int rc, nodeid; > ^ > = 0 > 1 warning generated. > > [...]
Applied to powerpc/fixes.
[1/1] powerpc/papr_scm: Ensure rc is always initialized in papr_scm_pmu_register() https://git.kernel.org/powerpc/c/6cf07810e9ef8535d60160d13bf0fd05f2af38e7
cheers
| |