Messages in this thread | | | Date | Fri, 2 Sep 2022 11:05:34 +0200 | From | Greg KH <> | Subject | Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result variable Return 0 instead of storing it in another redundant variable. |
| |
On Fri, Sep 02, 2022 at 11:54:46AM +0300, Dan Carpenter wrote: > On Fri, Sep 02, 2022 at 03:26:28AM +0000, cgel.zte@gmail.com wrote: > > From: lufengchang <lu.fengchang@zte.com.cn> > > > > Reported-by: Zeal-Robot <zealci@zte.com.cn> > > Signed-off-by: lufengchang <lu.fengchang@zte.com.cn> > > --- > > There is a lot wrong with the format of this patch. > 1) The subsystem prefix > 2) The blank line after the subject > 3) Line wrapping at 75 chars > 4) Your name is not capitalized > 5) Greg doesn't like Zeal-Robot tags.
I don't mind the tags, what I mind is that the users of this tool are not following what is documented in Documentation/process/researcher-guidelines.rst when using it.
thanks,
greg k-h
| |