Messages in this thread Patch in this message | | | From | Zhao Liu <> | Subject | [PATCH] KVM: SVM: Replace kmap_atomic() with kmap_local_page() | Date | Fri, 2 Sep 2022 17:08:11 +0800 |
| |
From: Zhao Liu <zhao1.liu@intel.com>
The use of kmap_atomic() is being deprecated in favor of kmap_local_page()[1].
In arch/x86/kvm/svm/sev.c, the function sev_clflush_pages() doesn't need to disable pagefaults and preemption in kmap_atomic(). It can simply use kmap_local_page() / kunmap_local() that can instead do the mapping / unmapping regardless of the context.
With kmap_local_page(), the mapping is per thread, CPU local and not globally visible. Therefore, sev_clflush_pages() is a function where the use of kmap_local_page() in place of kmap_atomic() is correctly suited.
Convert the calls of kmap_atomic() / kunmap_atomic() to kmap_local_page() / kunmap_local().
[1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com
Suggested-by: Ira Weiny <ira.weiny@intel.com> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> --- Suggested by credits. Ira: Referred to his task document and review comments. Fabio: Referred to his boiler plate commit message. --- arch/x86/kvm/svm/sev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 28064060413a..12747c7bda4e 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -465,9 +465,9 @@ static void sev_clflush_pages(struct page *pages[], unsigned long npages) return; for (i = 0; i < npages; i++) { - page_virtual = kmap_atomic(pages[i]); + page_virtual = kmap_local_page(pages[i]); clflush_cache_range(page_virtual, PAGE_SIZE); - kunmap_atomic(page_virtual); + kunmap_local(page_virtual); cond_resched(); } } -- 2.34.1
| |