Messages in this thread | | | Date | Fri, 2 Sep 2022 19:32:27 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2 08/59] x86/build: Ensure proper function alignment |
| |
On Fri, Sep 02, 2022 at 09:51:17AM -0700, Linus Torvalds wrote: > On Fri, Sep 2, 2022 at 6:55 AM Peter Zijlstra <peterz@infradead.org> wrote: > > > > --- a/arch/x86/include/asm/linkage.h > > +++ b/arch/x86/include/asm/linkage.h > > @@ -14,9 +14,10 @@ > > > > #ifdef __ASSEMBLY__ > > > > -#if defined(CONFIG_X86_64) || defined(CONFIG_X86_ALIGNMENT_16) > > -#define __ALIGN .p2align 4, 0x90 > > -#define __ALIGN_STR __stringify(__ALIGN) > > +#if CONFIG_FUNCTION_ALIGNMENT == 16 > > +#define __ALIGN .p2align 4, 0x90 > > +#define __ALIGN_STR __stringify(__ALIGN) > > +#define FUNCTION_ALIGNMENT 16 > > #endif > > Ugh. > > Why is this conditional on that alignment being 16?
There is a DEBUG case that increases the thing to 32.
| |