lkml.org 
[lkml]   [2022]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] bus: hisi_lpc: Use platform_device_register_full()
On 01/09/2022 18:47, Andy Shevchenko wrote:
>> + .name = "hisi-lpc-ipmi",
>> + .id = PLATFORM_DEVID_AUTO,
>> +
>> + .res = res,
>> + .num_res = num_res,
>> + },
> ...here and in the other cases you have a lot of blank lines, can we
> just get rid of them?

ok

>
>> + },
>> },
>> /* 8250-compatible uart */
>> {
>> .hid = "HISI1031",
>> - .name = "serial8250",
>> - .pdata = (struct plat_serial8250_port []) {
>> + .pdevinfo = (struct platform_device_info []) {
>> {
>> - .iobase = res->start,
>> - .uartclk = 1843200,
>> - .iotype = UPIO_PORT,
>> - .flags = UPF_BOOT_AUTOCONF,
>> + .parent = hostdev,
>> + .fwnode = acpi_fwnode_handle(child),
>> +
>> + .name = "serial8250",
>> + .id = PLATFORM_DEVID_AUTO,
>> +
>> + .res = res,
>> + .num_res = num_res,
>> +
>> + .data = (struct plat_serial8250_port []) {
>> + {
>> + .iobase = res->start,
>> + .uartclk = 1843200,
>> + .iotype = UPIO_PORT,
>> + .flags = UPF_BOOT_AUTOCONF,
>> + },
>> + {}
>> + },
>> + .size_data = 2 *
>> + sizeof(struct plat_serial8250_port),
> I believe this can be one line.

I think so, as we're exceeding 80 char width anyway.

>
>> },

Thanks,
John

\
 
 \ /
  Last update: 2022-09-02 08:47    [W:0.174 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site