Messages in this thread | | | Date | Fri, 2 Sep 2022 19:30:39 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v2 2/6] x86/sgx: Do not consider unsanitized pages an error |
| |
On Fri, Sep 02, 2022 at 09:08:23AM -0700, Reinette Chatre wrote: > Hi Jarkko, > > On 9/2/2022 8:53 AM, Jarkko Sakkinen wrote: > > On Fri, Sep 02, 2022 at 04:26:51PM +0300, Jarkko Sakkinen wrote: > >> + if (ret) > >> + pr_err("%ld unsanitized pages\n", left_dirty); > > > > Yeah, I know, should be 'left_dirty'. I just quickly drafted > > the patch for the email. > > > > No problem - you did mention that it was an informal patch. > > (btw ... also watch out for the long local parameter returned > as an unsigned long and the signed vs unsigned printing > format string.) I also continue to recommend that you trim
Point taken.
> that backtrace ... this patch is heading to x86 area where > this is required.
Should I just cut the whole stack trace, and leave the part before it?
BR, Jarkko
| |