Messages in this thread | | | From | Christophe Leroy <> | Subject | Re: [PATCH v2 2/2] powerpc/math-emu: Remove -w build flag and fix warnings | Date | Fri, 2 Sep 2022 16:11:33 +0000 |
| |
Le 02/09/2022 à 17:59, Segher Boessenkool a écrit : > On Fri, Sep 02, 2022 at 08:37:23AM -0700, Nathan Chancellor wrote: >> On Fri, Sep 02, 2022 at 12:08:55PM +0200, Christophe Leroy wrote: >>> This should have been detected by gcc at build time, but due to >>> '-w' flag it went undetected. >>> >>> Removing that flag leads to many warnings hence errors. > >> Thanks for figuring out what was going on here! I took this patch for a >> spin with clang and it has a few more errors around >> -Wimplicit-fallthrough: > > Maybe add -Wno-implicit-fallthrough? This code is a copy from outside > the kernel, no one has ever wanted to maintain it, if nothing else (the > more politically correct formulation is "we cannot as easily pick up > improvements from upstream if we modify stuff"). >
There are already such changes in that common file, see for instance commit f336a009f8e3 ("math-emu: Fix fall-through warning"), was in July 2021.
Christophe
| |