Messages in this thread | | | Date | Fri, 2 Sep 2022 18:05:05 +0200 | Subject | Re: [PATCH v2 01/59] x86/paravirt: Ensure proper alignment | From | Juergen Gross <> |
| |
On 02.09.22 15:06, Peter Zijlstra wrote: > From: Thomas Gleixner <tglx@linutronix.de> > > The entries in the .parainstr sections are 8 byte aligned and the > corresponding C struct makes the array offset 16 bytes. > > Though the pushed entries are only using 12 bytes. .parainstr_end is > therefore 4 bytes short. > > That works by chance because it's only used in a loop: > > for (p = start; p < end; p++) > > But this falls flat when calculating the number of elements: > > n = end - start > > That's obviously off by one. > > Ensure that the gap is filled and the last entry is occupying 16 bytes. > > Cc: Juergen Gross <jgross@suse.com> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen [unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |