lkml.org 
[lkml]   [2022]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v4 6/8] EDAC: Add the ghes_edac_preferred check for chipset-specific edac drivers
    Date

    On Wednesday, August 31, 2022 1:40 AM, Jia He wrote:
    > edac_mc_add_mc* is too late in the init path and that check should happen
    > as the very first thing in the driver init function.
    > Add the newly introduced helper ghes_edac_preferred() for the platform
    > check.

    I'd suggest to rephase a bit, something like:
    ==
    Add ghes_edac_preferred() check to chipset-specific edac drivers to ensure
    that ghes_edac is used on the platform where ghes_edac is preferred over
    chipset-specific edac driver.

    Unlike the existing edac_get_owner() check, the ghes_edac_preferred() check
    works independent to the module_init ordering.
    ==

    Otherwise, the patch looks good to me.
    Reviewed-by: Toshi Kani <toshi.kani@hpe.com>

    Toshi

    \
     
     \ /
      Last update: 2022-09-02 17:58    [W:5.533 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site